Melvin Aguilar π§π»βπ»β’ 61,220
@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some feedback for you if you want to improve your code.
- There isn't much information about what the button is for, and
icon-dice
as thealt
attribute value is not very descriptive, screen reader users will hear "Button, icon-dice" and they won't understand what the button does. You can useGenerate new advice
as thealt
attribute value. You can see an example here.
- Not all images should have alt text. The divider image is a decorative image, it does not add any information to the page. You should use an empty
alt
attribute instead of a descriptive one. You can read more about this here π.
- Note: The Advice Slip JSON API documentation says that the repeat requests within 2 seconds will return the same response
CSS π¨:
- Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the
text-transform
property to transform the text to uppercase in CSS.
I hope you find it useful! π
Happy coding!
2