advice generator using JS HTMl CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,160

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  • Not all images should have alt text. The divider image is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here.

  • Adding functionality to non-interactive elements like div or img is not recommended because they are not designed to be interactive. You should use interactive elements like button to make your elements interactive.

  • The <div class="circle"> element has another problem when changed to a button. There isn't much information about what the button is for, and dice-icon as the alt attribute value is not very descriptive, screen reader users will hear "Button, dice-icon" and they won't understand what the button does. You can use Generate new advice as the alt attribute value. You can see an example here.

  • Since I can currently spam it with clicks, it would be better if you added a delay of for example 2 seconds. Block the button and with the setTimeout function enable the button again after 2 seconds.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1