Submitted over 1 year ago

Advice generator app

Muhammad• 40

@Latifkhonov

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

HTML
CSS
JS
API

2junior

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hello everyone, it is honor to be one part of Frontend Mentor community.I have already finished my first junior project and I am doing my best to be one of the well experienced Frontend developers. I really need to your advices in order to move forward during my developing tour.

Good luck for evryone.

Community feedback

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

C H A R A N 🎯• 2,690

@0xabdul

Posted over 1 year ago

Hello Developer well congratulations on successfully completing the Advice generator app

A Some suggestions for improve your code
In Html 📃 :
LANDMARK 🚀
The main landmark should be a top-level landmark. When a page contains nested document and/or application roles (e.g. typically through the use of iframe and frame elements), each document or application role may have one main landmark. If a page includes more than one main landmark, each should have a unique label.
To Clear the Accessibility reports use the Semantic elements Or non - Semantic elements
Note This Elements are don't sikp
semantic elements : <aside> , <artical> , <main>, <header> ,<section><footer>, <form> ect..
non- semantic elements : <div> , <span> ect ...
for easy way to clear the Accessibility reports using non semantic elements Ex :

<body>
<div class="container" role="main">
/html code goes here : 📃
</div>
</body>

Or
using semantic elements
Ex :

<header>
should be put heading or logo📸
</header>
<nav>
//Links here
</nav>
<main>
Main of the contents 📃
</main>
<footer>
©copy right  here📍
</footer>

HEADING ⚠️
The page must contain at least one h1 element identifying and describing the main content of the page. An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
So fix them
Ex :

<h1> </h1>
<h2> </h2>
<h3> </h3>

Note : we use the headings line by line in order way
I Hope you find the solution and it's useful for you and your project is great Happy Coding Developer

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord