Advice generator app

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey!

  • Page should contain a level-one heading, Change <div class="header"> to <h1 class="heading">

  <h1 class="heading">ADVICE #<span class="id">79</span></h1>
  

  You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • This <div class="dice-div"> Should be <button>... Buttons are used for actions.

  <button class="btn-dice">
  		<img src="images/icon-dice.svg" alt="Advice Generator">
  </button>
  

  • I suggest you learn about CSS preprocessor (Sass).

  Hope this is helpful to you👍

  Marked as helpful

  1