Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app using HTML, CSS and JavaScript

@DanielLucaci

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my solution for the "Advice generator app" challenge. I spend some time to add a loading spinner when fetching a new advice, but I'm very proud of the final result. Any feedback is highly appreciated.

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hello Lucaci, You have done a good work! 😁

Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that element
  • use article or blockquote tag instead of main tag to the container card for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px or % use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help 😉 and Happy coding!

Marked as helpful

1

@catherineisonline

Posted

Wow this looks great, the spinner is a great addition to this, might steal the idea later 😃

3

@DanielLucaci

Posted

@catherineisonline Hey, thanks for your feedback. If you want to steal the idea with the loading spinner, then feel free to do it. :)

0
nourahmed 150

@nour-elhabbal

Posted

It's Perfect and the additions u made are adorable , I'll use the additions u made if u don't mind :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord