Advice generator app using HTML, CSS and JavaScript

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Lucaci, You have done a good work! 😁

  Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that element
  • use article or blockquote tag instead of main tag to the container card for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px or % use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Wow this looks great, the spinner is a great addition to this, might steal the idea later 😃

  3

  ---

  

  Lucaci Daniel•220

  @DanielLucaciPosted almost 2 years ago

  @catherineisonline Hey, thanks for your feedback. If you want to steal the idea with the loading spinner, then feel free to do it. :)

  0
• 

  nourahmed•150

  @nour-elhabbalPosted about 1 year ago

  It's Perfect and the additions u made are adorable , I'll use the additions u made if u don't mind :)

  0