Advice Generator Web App with Flexbox, BEM and Basic Error Handling.

Community feedback

• 

  James•160

  @jamescheinPosted almost 2 years ago

  Hi Mr Enthusiast, You made a great job of the UI with some good lean HTML structure and fine CSS work.

  Some pointers - // The functionality is missing for changing the cards - is this to come?

  // The HTML and class naming could be more semantic and obvious - eg <main> might benefit from a class of 'advice__card'. Even better would be to use a <div class="advice__app> or landmark element [section, article, etc] inside the <main> element which is traditionally used as a top level page structure element like <header> and <footer> etc. This would serve you better if you wanted to port the advice application as a self-contained component wholesale to other sites in future.

  Hope this helps. Best to you! James :)

  Marked as helpful

  1

  ---

  

  Mr. Enthusiast•20

  @mrenthuPosted almost 2 years ago

  @jameschein Thank you so much! I will note your suggestions in readable way and then improve them in time! If you want to add something else, write here or on GitHub. See you in next msg!

  0