Advice Generator App

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Good morning Jhan.

  You have done a good job so far. Another push will make your project very close to the design. Notably the container has a border radius and the initial text is not centered as per design. Creating a new element on the click of a button is causing an additional attachment of the created element. I would opt to change the innerHtml of the dynamic content. Take note as well that an interactive element such as a button should have readable text, an image is not enough.

  0
• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  Hi, Great work espically on design part. There is a bug which i found :

  1. sometimes same advise appear twice on the screen. I think when i click the button in qucik succession. Try disabling the button until you get back the result from network request.

  Also, Why are you asking user to click button to get initial advice. Make initial request when the page loads.

  and also it would feel good to the user if you can add some "active" state on button.

  Other than that it looks great.

  Good Luck

  #happyCoding

  0

  ---

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  @besttlookk, to answer your first question, according to the api docs, you have to wait for at least 2 seconds to generate a new request

  0