Advice generator app solution with Flexbox, async/await

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hi, Magdalena! 👋

  Great work on this challenge! 👍 Glad to hear that you learned a lot! 😊

  A couple of things I'd like to suggest are,

  • Leaving the alt text for the dice image empty since it doesn't really add anything to the content of the page and therefore doesn't need to be noticed by screen readers.
  • Labeling the button in some way, either by adding an aria-label or perhaps by adding some invisible text inside it for screen readers to read.
  • You don't need to set the innerHTML of the advice element to be empty first in your JS, you should just be able to set the element's textContent to the new advice directly (as in, overwrite it). 😉

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1

  ---

  

  Magdalena•140

  @MagdalenaBrPosted almost 2 years ago

  @ApplePieGiraffe Thank you very much for suggestions😊

  1
• 

  Youssif•280

  @Youssif94Posted almost 2 years ago

  The "advices" are stuck for me, it doesn't generate a new one by clicking the button unless I refresh the whole page.

  0

  ---

  

  Magdalena•140

  @MagdalenaBrPosted almost 2 years ago

  @Youssif94 It takes a little time to load advice (about 1—2s)

  0