Advice Generator App

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="main-box"> instead of <div class="main-box">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You should add a alt text to your img tag to aid screen-readers.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  1

  ---

  

  Matheus Pergoli•130

  @matheuspergoliPosted over 2 years ago

  @Samadeen Thanks for your feedback :D

  0
• 

  P

  Karthik suryadevara•825

  @karthik2265Posted over 2 years ago

  Looks great, well done 👏

  I liked how you used HTML custom data properties for selection in js. The js code is well written and easy to read. why did you place the js and css files in the assets folder, I think they go in a separate folders or just in the root.

  You forgot to add the hover effect for the button, you can easily add the effect with the following code box-shadow: -1px 0 40px 2px var(--Neon-Green), 1px 0 40px 2px var(--Neon-Green); filter: brightness(1.1);

  1

  ---

  

  Pablo Montoya Varela•300

  @PaliTriesToDesignPosted over 2 years ago

  @karthik2265 and don't forget to add a nice transition to it c:

  .data-btn-generator {
       transition: all 200ms ease-in-out
  }
  

  2

  

  Matheus Pergoli•130

  @matheuspergoliPosted over 2 years ago

  @karthik2265 Thanks for your help man, I didn't know how to do that glowing effect :)

  0

  

  P

  Karthik suryadevara•825

  @karthik2265Posted over 2 years ago

  @PaliTriesToDesign nice

  0

  

  P

  Karthik suryadevara•825

  @karthik2265Posted over 2 years ago

  @matheuspergoli no problem

  0
• 

  Igor Ostojic•300

  @igor-ostojicPosted over 2 years ago

  Hey ! Great work so far !

  So for the element "data-btn-generator" If you want to make it a perfect circle, it needs to have both a height and a width with the border radius at 50%.

  As for the JavaScript, it all looks good to me !

  1

  ---

  

  Matheus Pergoli•130

  @matheuspergoliPosted over 2 years ago

  @igor-ostojic Thanks for your feedback! :D

  0