Advice Generator App

Community feedback

• 

  Keytron•270

  @Dev-TronPosted over 2 years ago

  It is not a bad practice to use negative margin. A general rule of thumb is that if it looks good then it usually is good. You could also simply apply position: relative; to your parent divs and then the position: absolute values (ie. top:; right:; bottom:; left:;) to child elements which can help you avoid using negative values greatly.

  Marked as helpful

  0
• 

  Oleh Karaulnyi•40

  @karaaa006Posted over 2 years ago

  You can use transform: translateY(50%) for that

  Marked as helpful

  0
• 

  P

  Nikolas Escobal•230

  @nikoescobalPosted over 2 years ago

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I think using negative margins is completely fine, although it should only be used when necessary. The alternative is to use absolute positioning -- keep in mind that if you do use absolute positioning, the parent container must have a position relative applied to it.

  Here's some other feedback on this solution:

  • you forgot to add the quotation marks
  • You can add width to your content + text-align-center to make it look like the original design
  • check the report to fix accessibility issues - you currently have 5 listed

  I hope this is helpful and all the best with your coding journey!

  Marked as helpful

  0