Advice generator app made with HTML/CSS/JavaScript

Community feedback

• 

  madhaus•1,040

  @festsnusaPosted almost 2 years ago

  Hi there! Congratulations for completing this challenge.

  Here's my feedback:

  • to center your divider, you can use "left: 50%" and "transform: translateX(-50%)";
  • when clicking more than once within 2 seconds, the second click is ignored. you can set timeOut with 2 seconds;
  • importing google fonts instead of downloading fonts is not a good practice, because anything could happen — fail to connect to link or the actual link may become unavailable. to download fonts, you can use "google-webfonts-helper";
  • i think wrapping "main — wrapper — card" looks kinda complex. you can simplify it to "main class='card'";
  • i don't think putting 2 images inside .dividers is a good idea. you can change the image via media query;
  • putting div inside a is not a good idea. only "inline-block" elements are recommended. plus, your whole div section will act as a link;
  • alts are empty;
  • in CSS, h1 declared twice;
  • for media queries, you can only set for desktop resolution;
  • your box-shadow looks okay;

  Hope you're gonna find my feedback useful. Happy coding.

  Marked as helpful

  1