Advice generator app

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Demy, well done in putting this together! The only issue for me is I can't load the next advice because of caching in Firefox, and so to fix this, try adding a header object in fetch, like this:

  fetch("https://api.adviceslip.com/advice", { cache: 'no-cache' })
  

  I would also include a cursor: pointer with your dice so that users know it is interactive. That's all the comments I have, good work here, and hope to test this out again!

  Marked as helpful

  1

  ---

  

  demy•190

  @DemyttenaerePosted about 2 years ago

  Hi @elaineleung,

  Thanks a lot for your advice! I will take your advice into account for the next challenges and will come back to this one soon!

  Good coding

  1
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @Demyttenaere,

  Great job on completing the challenge

  Just something small on the body add min-height: 100vh; this will the center the card the vertically and horizontally on the page.

  Hope this is helpful.

  Marked as helpful

  0

  ---

  

  demy•190

  @DemyttenaerePosted about 2 years ago

  Hi @hyrongennike,

  Thanks a lot for your advice!

  Good coding

  0