Advice Generator App 2KMiguel64 Solution

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey! It looks good!...

  My suggestions:

  • Document should have one main landmark, Contain the component with <main>.
  • Page should contain a level-one heading, Change <div class="card__header"> to <h1 class="card__header"> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.
  • I also suggest you use <button class="card__button"> instead of <div class="card__button">... Buttons are used for actions.

  <button  
      className="card__button" 
      onClick={ fetchQuote }
      >
        <img 
             src="./assets/icon-dice.svg" 
             alt="Advice Generator" 
             />
  </button>
  

  I hope this is helpful to you... Keep coding👍

  Marked as helpful

  1

  ---

  

  2KMiguel64•50

  @Miguel-Arturo-Madrigal-EscotoPosted over 2 years ago

  @Bayoumi-dev thanks for your advice. Very helpful

  0
• 

  Kehinde•660

  @jonathan401Posted over 2 years ago

  Congrats on completing the challenge 🎉🎉. I used my mobile phone to check it out and it looks great 😇. One suggestion though. When I clicked the 'view code' to see your code on GitHub, it lead me to your GitHub profile. It should lead to your project repo. When submitting any challenge, in the form where you are prompted to enter your repository URL, you should enter the URL to the repo where your code is and not to your GitHub profile. This makes it easier for anyone who wants to give a feedback on your code 🤗. Hope this helps 😁. Congrats on completing the challenge 🎉🎉🎉

  Marked as helpful

  0

  ---

  

  2KMiguel64•50

  @Miguel-Arturo-Madrigal-EscotoPosted over 2 years ago

  @jonathan401 sorry, I didn't realize I had put the wrong link. Thanks (:. Now it's fixed.

  1