Advice generator app

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  Greetings Manish

  • since these are quotes , i would prefer to use the blockquoteelement.
  • use a button for the div with a class of advice-btn, a div is not an interactive element and will not be accessible to assistive technology users - it will require a lot more coding to get the same functionalities

  Marked as helpful

  1

  ---

  

  Manish Manwani•30

  @ManishManwani36Posted almost 3 years ago

  @ChamuMutezva thanks for the feedback! Looking at it now I can see accessibility would definitely be an issue with the button. The block quote element makes sense since it should be readable for people using screen readers

  0
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @ManishManwani36, Wonderful work!

  0