Skip to content
Submitted over 2 years ago

Advice generator app

Darren Wong•110
@wongd-hub
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

Hey all - would appreciate any comments you may have on the JS implementation here, unsure if I've been the most efficient I can be.

Community feedback

  • Uzair Ahmed•170
    @uzzii-21Posted over 2 years ago

    Hello @wongd-hub Hope you are well. I checked your solution and you did a great job :)

    Here is my feedbacks

    • If you are using only one heading tag, make sure it should be * h1 *. And if you are using more than one heading tag then make sure it should be in logical order like: first h1 then h2 ...
    • Note that you cannot use more than one h1 in a page but h2, h3 you can.
    • Add a lang attribute to the html element (e.g. <html lang="en">) whose value represents the primary language of document.
    • Anchor tag must have discernible text if you can't use text then you should use aria-label

    Hope it will help you :) Happy Coding

    Marked as helpful
    0
  • Darren Wong•110
    @wongd-hubPosted over 2 years ago

    Thank you! Will implement these next time I'm able to.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord