Travolgi 🍕• 31,420
@denielden
Posted
Hello Spencer, You have done a good work! 😁
Some little tips to improve your code:
- not use javascript inside html but use hook inside the js files like this:
document.body.addEventListener('event', functionName)
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article or blockquote
tag instead of a simplediv
to the container card for improve the Accessibility - you can use
picture
tag to change image by resolution -> read here - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0