Advice Generator API

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 1 month ago

  Hi achraf hafid, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  I noticed that your card is growing and shrinking when the resolution is due to the use of vh, what can you do to improve it:

  body {
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  and:

  .main {
      max-width: 320px;
      height: 240px;
      width: 100%;
      background-color: hsl(217, 19%, 24%);
      /* margin-top: 17%; */
      border-radius: 20px;
  }
  

  The rest is excellent.

  I hope you find it useful. 👍

  Marked as helpful

  0