Advice Generator

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 2 years ago

  Hello Felipe! Nice solution overall!

  I found a small redundancy (in my opinion) in your fetch advice. Here is my improvement.

  const getAdvice = () => {
      fetch("https://api.adviceslip.com/advice")
      .then(r => r.json())
      .then(data =>  generateAdvice(data.slip));
  }
  //if you want to be clearer, you can destructure and rename.
  .then(({ slip : advice }) =>  generateAdvice(advice));
  
  

  I hope it helps! Cheers!

  Marked as helpful

  1

  ---

  

  Felipe Oliveira•95

  @feliveiraPosted over 2 years ago

  Hi Fazza! Wow, it sure helped, thanks for the feedback and for teaching me this other way! :D

  0