Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator

@ViniciusMassari

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Abdul Khaliq ๐Ÿš€โ€ข 72,660

@0xabdulkhaliq

Posted

Hello there ๐Ÿ‘‹. Congratulations on successfully completing the challenge! ๐ŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS ๐ŸŽจ:

  • Using min-height: 80vh; will only places the element on 80% of the whole screen
  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here ๐Ÿ“™.
body {
    min-height: 100vh;
    display: grid;
    place-items: center;

    margin: 0;
}

I hope you find it helpful ! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord