Advice Generation ReactJs

Community feedback

• 

  P

  Jakub Strzyżykowski•260

  @jstrzyzykowskiPosted 2 months ago

  Good job!

  One small tip:

  • define new local state called "isLoading" as a flag
  • switch this flag each time when your request is pending
  • when "isLoading" is true, you can display some kind of loader on UI

  It will significantly improve user experience 🙂

  Keep going!

  Marked as helpful

  1

  ---

  

  kudos2Shef•210

  @kudos2ShefPosted 2 months ago

  @jstrzyzykowski Thanks for the tip! I'll definitely keep that in mind for my next code.

  0
• 

  Sophie•430

  @ippotheboxerPosted 2 months ago

  Well done, the app looks great, and I like the animation you added with the dice. Your code is lean and well written. One thing you could have done in regards to getting the data with fetch, instead of setting the initial value to something hard coded along with the id, you could use useEffect and call fetchAdvice:

  const [advice, setAdvice] = useState("")
  const [id, setId] = useState()
  
      useEffect(() => {
          fetchAdvice() 
      }, []) // empty dependency array means this is used on render
  

  Whilst leaving everything else the same. This means you don't have a hard coded initial value, and useEffect will be used initially when the app is loaded and on any refresh.

  Marked as helpful

  1

  ---

  

  kudos2Shef•210

  @kudos2ShefPosted 2 months ago

  @ippotheboxer Thanks for the feedback! I'll make sure to make changes in my next code.

  1