Design comparison
SolutionDesign
Solution retrospective
For some reason, in firefox, it fetches the same id everytime. Whereas in Chorme everything works fine. Maybe someone else knows what the reason is?
Other than that, it was a cool challenge. Especially that I'm starting with React now and already feel quite confident. I will gladly accept any suggestions for improvement!
Happy Coding! 👨💻
Community feedback
- @0xabdulPosted over 1 year ago
Hey there ! 👋 Congratulations you finished the Advice generated app...🎉
- some suggestions for you improve your code
Html 🏷️:
- for Accessibility reports you using the and div tag to wrap the whole html code and put attribute role="main" is correct way 🎯 and using the header tag those all are problem to occur the Accessibility reports for example...
<body> <div class="container" role="main"> //Whole html code <h1> </h1> <h2> </h2> <h3> </h3> //by ordering using the header tag </div> </body>
- I Hope it's useful for you and wating for your next project ❤️
- Happy Coding 😃
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord