Design comparison
Solution retrospective
Found adding background image using tailwind css a little tricky. But after a fair bit of searching, was able to manage it.
Community feedback
- Account deleted
Really impressed with your solution! I like the small details like the fade animation in-between switching between advices. You also have a proper try-catch method for catching any unwanted errors. If you'd like to improve the solution even further, I would suggest tracking if the previous advice is the same as the one being fetched. If it is then refetch. This would potentially remove any duplicates whenever the user is trying to fetch a new advice.
Great work!
//Kenny
Marked as helpful0@gtalinPosted over 1 year ago@ktra99 Thank you for your feedback and suggestion on how to improve the solution further.
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution had generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0@gtalinPosted over 1 year ago@0xAbdulKhalid thank you for your feedback and suggestion regarding how to add it for visually impaired users without adding it for visual users.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord