Design comparison
Solution retrospective
I found difficult to add random advice functionality, but finally I found a solution which is not recommended but it worked.
At the begginnig it was very challenging, but I made it, and am plaaning to add new features like translating advices quotes to other languages.
Please feedback, suggestions, I always looking to learn ! :)
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Kevin Brian, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
Prefer to use
removerpxto have your page working better across browsers and resizing the elements properlyThe rest is great!!
Hope it helps...👍
Marked as helpful1 - @davidbabatundePosted about 2 years ago
Nice work bro. To make the random functionality work, your get request should not have any additional props. Just use "https://api.adviceslip.com/advice" directly. This will return a random advice each time. Wish you the best.
Marked as helpful1@realkevinbrianPosted about 2 years ago@davidbabatunde Thank you, for your feedback...
I tried that, what happens If a user click on random button, it should return new random quote without refreshing the whole page.
Any idea to deal with that?
0@realkevinbrianPosted about 2 years ago@davidbabatunde Thank you, for your feedback...
I tried that, what happens If a user click on random button, it should return new random quote without refreshing the whole page.
Any idea to deal with that?
0@davidbabatundePosted about 2 years ago@realkevinbrian You can put your entire axios call into a function, then onclick={theFunction}. Remember this will also be without any props, so it randomly picks any quote and returns it for your use. I'll post my solution in the next few minutes, I have quite a number of things I need help with. But this part works fine.
Marked as helpful1@realkevinbrianPosted about 2 years ago@davidbabatunde Thank you , I will try it bro!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord