Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
next time will try to use Sass and stylus
What challenges did you encounter, and how did you overcome them?media query
What specific areas of your project would you like help with?media query
Community feedback
- @andrew-g-ayadPosted 7 months ago
You already did a great job creating root-level custom properties. I recommend you to do the following:
- don't set heights unless you need to
- don't use id's to style elements (it works but is not a best practice)
- use more semantic HTML (for example you could use the
h1
tag for the title) - Double-check width values in the design
I highly recommend you give these a go before moving to more advanced tools like sass
1@Amit-MahiPosted 6 months ago@andrew-g-ayad thanks for the great feedback.
- I was actually having problem with the heights i guess you solved them.
- for the styles i will use the class for now.
- for the Semantic HTML first i was thinking to use h1 but i don't know why i didn't do that.
thanks again I really appreciate the time you took and write very helpful feedback. I hope i will face more error but not these ones.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord