@denielden
Posted
Hi Jefferson, congratulations on completing the challenge, great job! 😁
Some little tips for optimizing your code:
- Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - remove descriptive text in the
alt
attribute of the icon images because there is only decorative - remove all
margin
frommain
tag because with flex they are superfluous - add
transition
on the element with hover effect
Hope this help! Happy coding 😉
Marked as helpful
@Jorggyh
Posted
@denielden the margin is for my project to be in the same position as the challenge design, without this margin my project would be above, their design is not in the center (strange isn't it?)
The other tips are very good, thanks!
@denielden
Posted
@Jorggyh You are welcome!
It depends on the resolutions of the monitors and the screen that is done ... still great job ;)
Keep it up Jefferson :)