Accordion-card site using HTML, CSS, Flexbox and Grid

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Daniel M.! 👋

  Nice to see you complete your second Frontend Mentor challenge! 🎉 Good effort on this challenge! 👏

  I suggest only using <article> tag when you have a heading inside them to identify them and they make sense with additional context from a parent element. In this challenge, I think you can simply use another tag (such as <li>) for the FAQs.

  Your positioning of the background images seems okay! 👍 You could add the floating cube as a pseudo-element to the accordion card and absolutely position it relative to the card itself. In the mobile layout, I'd recommend adding a little more space between the top of the card and the top edge of the page so that the top of the hero image doesn't get cut off at certain screen heights.

  And think the next step you can take towards adding on to and improving your solution would be to make the accordion card interactive by opening/closing the various FAQs when they are clicked on. 😉

  Keep coding (and happy coding, too)! 😁

  0