Accordion FAQ

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Sloth!

  Thanks for leaving kind words on my solution!

  I can close the panel that I opened, in my opinion there's nothing wrong with it.

  Some feedback on this solution:

  • For the icon arrows, they are decorative images. You can add aria-hidden="true" and leave the alt="".
  • For padding, margin, gap, I recommend to use rem or em units instead of %. The reason for that is, you can't limit the max padding, which means it might not be looking good on wide screen.
  • Also 640px is too early to change the layout into two columns.
  • Try to do this challenge using JavaScript, since the non JavaScript version is just additional challenge.

  That's it! Hopefully this is helpful!

  Marked as helpful

  0

  ---

  

  Yuko Horita•645

  @Sloth247Posted about 3 years ago

  @vanzasetia Thank you very much for your feedback! I meant closing all other panels when one panel is open, but I guess I need to use JavaScript to make this work.

  I will reflect your advice and will update my solution. Thank you very much 😊

  0
• 

  T

  Grace•31,890

  @grace-snowPosted over 3 years ago

  Hi this needs quite a lot more work, including making it look good on all screen sizes.

  Look up how to build "inclusive collapsible sections". There are some good resources out there.

  Good luck

  1