@Jonhillupperton
Posted
Hello Grzegorz,
Well done on submitting your solution to this challenge.
Few bits of advice to help you.
I wouldn't use position absolute on this, I have done the same challenge and I use Flexbox, not sure if you are experience with it. In the CSS by adding the following to the various elements you will center on the page in desktop and mobile mode. You won't need a media querie.
body { Min-Height: 100vh; Display: Flex; Flex-Direction: Column; Justify-Content: Center; Align-Items: Center;
.container { Max-Width: 320px; }
IMG { Width: 100%; Display: block; }
Also try and use rem for most of the elements (font-size, margin and padding) with the main html tag, you have place that within a div tag ideally you want that to be the first tag used after the body tag and assign the main tag class of container. The frontend mentor message at the end place that in a div.
it is a journey we are all on and keep learning and do the projects you will find your own way of doing these.
Thanks
Jon
Marked as helpful
@GregW1994
Posted
@Jonhillupperton Thanks for kind words and your remarks. Flexboox indeed is a better way to set up the layout for this project.
I appreciate the feedback
Best regards, Grzegorz