A website with Sass

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, nice work, Uririoghene Utobivbi! 👍

  Your solution looks good and works well! 🙌

  I suggest,

  • Allowing users to scroll within the accordion (or perhaps allowing the height of the accordion to grow) so that the text content doesn't overflow the accordion when multiple tabs are opened.
  • Adding a subtle box-shadow around the accordion (as in the original design).
  • Perhaps only making the titles of the FAQs bold when they are clicked on (as in the original design, as well).

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Uririoghene Utobivbi•70

  @RonarexxPosted about 4 years ago

  @ApplePieGiraffe Thanks a lot for your feedback, i would do well to make those changes suggested.

  0
• 

  Anna Leigh•5,135

  @brasspetalsPosted about 4 years ago

  Overall, a good job! 👍

  Just a few quick suggestions:

  • adding alt tags to your img elements will get rid of the accessibility and html errors
  • adding list-style: none to your summary should get rid of the black arrows that show up on the left of your details elements in Firefox.

  1
• 

  Uririoghene Utobivbi•70

  @RonarexxPosted about 4 years ago

  Thanks a lot @brasspetals your suggestions were very helpful

  0