Dreamleaf• 230
@Dreamleaf
Posted
Good job!
Just a couple of notes on using css grid.
In your css you have included width:100%, this isn't needed as a grid element is 100% by default.
Also, you are using height:100vh, while not wrong, there are better units to use. Check out SVH and DVH - the problem with using just VH is that on smaller views (mobile etc) it takes unwanted elements into account - like the address bar.
Hope this is helpful.
Marked as helpful
2
Nipaaaa1• 350
@Nipaaaa1
Posted
@Dreamleaf Thanks! I just checked about SVH and DVH, gonna use it on the next project.
0
