Submitted 11 months ago
A Simple Solution with HTML & CSS (Feedback is appreciated)
@Nipaaaa1
Design comparison
SolutionDesign
Community feedback
- @DreamleafPosted 11 months ago
Good job!
Just a couple of notes on using css grid.
In your css you have included
width:100%
, this isn't needed as a grid element is 100% by default.Also, you are using
height:100vh
, while not wrong, there are better units to use. Check out SVH and DVH - the problem with using just VH is that on smaller views (mobile etc) it takes unwanted elements into account - like the address bar.Hope this is helpful.
Marked as helpful2@Nipaaaa1Posted 11 months ago@Dreamleaf Thanks! I just checked about SVH and DVH, gonna use it on the next project.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord