A Simple Responsive Qr-code Scanner

Community feedback

• 

  Enmanuel Otero Montano•2,155

  @Enmanuel-Otero-MontanoPosted over 2 years ago

  Hello Viraj!

  For this case, flexbox is the most optimal way to center the div, I consider it.

  On the other hand, consider using relative units ( rem or em ) to size your font, as it can be adapted to the user's needs.

  Finally. I would like to ask why you decided to style in the HTML and not in a separate CSS file?

  Cheers!

  Marked as helpful

  0

  ---

  

  Viraj Chavan•100

  @viraj308Posted over 2 years ago

  @Enmanuel-Otero-Montano Thanks for your suggestions sir, I will learn these relative units as soon as possible. I guess I really made a mess writing html and CSS in a same file. Thanks again for going through my code and pointing out my faults.

  0

  

  Viraj Chavan•100

  @viraj308Posted over 2 years ago

  @Enmanuel-Otero-Montano Sir, do you have any suggestions on landmark elements? What's the optimal way to use those in this project?

  0

  

  Enmanuel Otero Montano•2,155

  @Enmanuel-Otero-MontanoPosted over 2 years ago

  @viraj308 Hello!

  If your question is about the error that Frontendmentor marks in its report, I advise you to read the explanation that is when you click on the button that is left of the error ( Learn more ) of landmarks. There you will have a better and more complete explanation than I can give you, anyway I am going to leave you the link below to the explanation.

  Learn to avoid landmark mistakes

  If you do not understand something after reading the document, do not hesitate to contact me.

  You can also consult @vanzasetia

  Keep coding. Don't be discouraged 🦾🦾🦾

  0
• 

  Glow•140

  @TheAwesomeTechGirlPosted over 2 years ago

  next time try styling outside your HTML, it is safer and shows clearer work done.

  1

  ---

  

  Enmanuel Otero Montano•2,155

  @Enmanuel-Otero-MontanoPosted over 2 years ago

  @nwakego98

  I would add that it will allow you to work on modules in larger projects and will load your page much faster.

  0