Design comparison
SolutionDesign
Solution retrospective
I really didn't need Sass. :) What's the best approach to make this challenge? what can I improve in my code?
Community feedback
- @dnksebastianPosted 9 months ago
Hi Daniel,
congrats on finishing the project! Here's a couple of things I've noticed after looking into your code:
- there are a few noticeable differences between the design and solution, most importantly you can improve paddings and 'preparation time' section which should have a different background color than the whole recipe card,
- you can improve the structure of your code by using more semantic tags, such as <article>, <section> and <table>,
- it's recommended to use more descriptive alt attributes for accesibility, currently the 'image' information is redundant because it can be inferred from the <img> tag,
- it's possible to make the solution more responsive, for example check the resolutions between 480px and 800px.
Hope that helps, keep it up!
1@RadiantReversalPosted 9 months ago@dnksebastian thanks i'll make these changes after <3 I didin't even see the difference in preparation time cuz it's so soft lmao
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord