A Simple QR Code Web application with HTML and CSS
Design comparison
Solution retrospective
I'm happy with how I built the project. However, I'd still appreciate anyone taking the time to point out any mistakes in my code or instances where I didn't follow best practices.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute.
- The
alt
attribute should explain the purpose of theimage
.
- E.g.
alt="QR code to frontendmentor.io"
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
2@0xabdulkhaliqPosted over 1 year ago@IbraheemOmar Glad you found it helpful ! 🤠
0 - @Manoj-V-348Posted over 1 year ago
You've really produced a perfect solution for the given problem. Congratulations. One suggestion I may give you is that make the size of the images, text or whatever in terms of ' % ' values corresponding to their container [ Flexbox ]. This would make the page responsive even when it is viewed in ultra small screen widths.
1@IbraheemOmarPosted over 1 year ago@Manoj-V-348 I appreciate the feedback! I'll try adding this into my solution.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord