@vanzasetia
Posted
Hi, Purnima Kumar! 👋
Congratulations on finishing this challenge! 🎉
You have done the challenge really fast! But, I would not recommend focusing too much on time especially when you just get started. I recommend focusing on the code quality instead.
Some more suggestions.
- I suggest putting the
attributionoutside themainelement. It is not the main content of the site. So, I would recommend wrapping theattributionwithfootertag inside (or swapping thedivwithfooter).
<body>
<main>
page content goes here...
</main>
<footer class="attribution">
attribution links goes here...
</footer>
</body>
- I recommend improving the alternative text of the QR code by telling the users about the QR code. In this case, it will navigate the user to https://www.frontendmentor.io/ so I recommend improving the alternative text to "QR code to frontendmentor.io".
- Lastly, put all the CSS on its own file. It is best to separate the HTML and the CSS whenever possible. It may not be a big deal in this case. But, in large projects or multiple-page websites, external CSS can be reused on the entire website. Also, it makes styling easier to maintain because you only need to change the CSS file and then all pages would reflect the change.
Hope this helps. 🙂
Marked as helpful
@purnimakumarr
Posted
Hey Vanza,
Totally agree on the attributtion thing & thanks for the alternate text suggestion. Making those changes right after writing this reply. As for the separate stylesheet, I know it's better to put the CSS in a separate file but as it was a very small project & readability was not an issue, I left it in the HTML file only.
Thanks for the feedback.
@vanzasetia
Posted
@purnimakumarr I took a look at the updated solution. The alternative text for the QR code is not quite right. "QR Code by Frontend Mentor" is telling the users that the image is provided by Frontend Mentor.
The alternative text should tell what the image is about, not where the image is coming from.
For the CSS, it's good that you are aware that separating it is a good practice. 🙂
Marked as helpful
