A simple landing page with the Card component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The link to the Github repository is incorrect :(

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  • The alt attribute should not contain underscores or hyphens, it must be human readable and understandable. An "alt" attribute's purpose is to provide more information to screen reader users by being read by the technology rather than being interpreted as code.

  CSS 🎨:

  • Use min-height: 100vh instead of height: 100vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1

  ---

  

  Álisson Véras•30

  @fty57Posted almost 2 years ago

  @MelvinAguilar Dude, it was worth it. I have already added your recommendations. Thanks a lot for the feedback. More important than knowing how to use a tag is knowing the reason for it. And your feedback speaks to why. Very good. Thanks again.

  0