A simple CSS Card, only plain HTML and CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="card"> with the main tag and <p class="card-title dark-blue"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .card on the page using flexbox or grid instead of position: absolute, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .card on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .card on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Replace the width in .card with max-width for a responsive content. There is no need to give the img a max-height value.

  Give .card-text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0

  ---

  

  Dan Dunai•130

  @dunaidanPosted over 1 year ago

  @Hassiai, thanks for the feedback! I learned a lot from your comment and in the next projects, I will try to avoid sizes in px and will try to use the correct HTML tags.

  I didn't notice the report with errors before your message, before uploading the solution I checked the HTML code on v3.org and unfortunately, there were missing warnings about the main and header tags.

  I changed my code according to your comment with one little difference, I set the paragraph font size to 0.935rem and h1 to 1.5 rem.

  0