Submitted over 3 years ago
A simple challenge from Frontend Mentor solved using HTML, CSS and JS
@vshal-ch
Design comparison
SolutionDesign
Solution retrospective
I would appreciate some feedback on code itself or maybe some tips that i could use in future.
Community feedback
- @tedikoPosted over 3 years ago
Hello, Vishal! 👋
Well done on this challenge! Responds well, and looks good. What I can advise is:
- Since your
.header logo
image is decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers. - Use
<button>
element instead of<input>
with type of button. Both causes the form data to be submitted to the server but The difference is that<button>
can have content, whereas<input>
cannot (it is a null element). While the button-text of an <input> can be specified, you cannot add markup to the text or insert a picture. So <button> has a wider array of display options. - Wrap your social-icons into
<a>
anchor tags, since they'll redirect to another page.
Good luck with that, have fun coding! 💪
0@vshal-chPosted over 3 years ago@tediko Thank you very much for the feedback😁,
Happy coding😁.
0 - Since your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord