@R3ygoski
Posted
Hello @ZoitovNurulloh, congratulations on your project! It looks really good and closely resembles the proposed design, which shows that it's not just a simple card, but a great one.
I have a couple of tips regarding the use of font-size. I noticed that you used absolute units, px. I strongly recommend using rem instead because this unit adapts to the user's font size settings, making your page more responsive and accessible to people with vision impairments.
Another tip I'd like to share is about your HTML semantics. While it's well-structured, the order seems to be a bit off. Let me suggest the correct order and explain why:
<section class="card">: This should be your<main>, as it contains the main content, and<main>always comes after<body>.<header class="card__header">: This should be a<figure>, as<header>is typically used for introductory content, and the image isn't introductory—it's an illustration.<main class="card__main">: It would be more appropriate to use an<article>here because the content is self-explanatory and doesn't depend on the main context of the rest of the page.
I also noticed that there's a JS file in your GitHub repository. Consider removing it if it's not being used.
Once again, congratulations! Your project looks really good, and you're doing great. Keep practicing and improving. If you have any questions, please feel free to ask, and I'll do my best to help.
Marked as helpful
Hi @R3ygoski. Thanks for your feedback, I will definitely take your feedback into consideration in my next projects.
@R3ygoski
Posted
Hi @ZoitovNurulloh, I'm glad to hear that my feedback was helpful for you. I kindly ask if you found my comment useful and helpful, could you please mark it as "helpful"? As it would greatly assist me, and thanks in advance!
