Design comparison
SolutionDesign
Community feedback
- @AGutierrezRPosted 11 months ago
Hello there @Aymii-mh 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Wrap the primary content within the
<main>
tag instead of using it as a standalone component like a<div>
. - All the content should be contained within landmarks. Every page minimally needs a
<main>
element. - Dont use
<font>
as a element for text, you could use<p>
,<span>
or something else.
CSS and Styling:
- Implement CSS custom properties to define and utilize project colors more easily.
- Avoid using
px
forfont-size
, you could read this article to learn why. Letter spacing and line height must not be inpx
, userem
for all the font-related properties. - Instead of fixed widths, employ
max-width
andmin-width
for flexible and responsive design.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful1 - Wrap the primary content within the
- @Darkx-devPosted 11 months ago
Good Job! , However Some things seems to be odd
- The font
- Alignment of icons with it's labels
Happy Coding!❤️
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord