A responsive website with dropdown navigation

Community feedback

• 

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted about 2 years ago

  Hello @Jbsmall17 Congratulations on completing this challenge. I suggest to remove following shortcomings in the page to look it better.

  1. As per design nav should not show in mobile version but it is showing .
  2. While setting media query you have given min-width 375px and max-width 1000px . which makes no sense . It covers all types of devices like mobile , tab and desktop. For mobiles , set media query 375-500 and for desktop from 992-1440px.
  3. In mobile version , Container is not centrally aligned . You can do this by styling body tag like this : body{ min-height:100vh; display:flex; justify-content:center; align-items:center; }
  4. In mobile version, Main element is not properly styled . Hence image is overflowing its height .
  5. P element of main section is not styled . set its width and line-height properties to look like design.
  6. Apart from the above , there are accessability & html issues as per report. Like img element should always have alt attribute and button should not contain anchor tag etc . You can remove them to get zero error report.

  I hope my feedback will help to make your code better. Thanks for reading.

  0

  ---

  

  Alao abdulmusawwir•130

  @Jbsmall17Posted about 2 years ago

  @rameshkmunjal thanks for you honest feedback. I will try to implement your feedback on this challenge and future project

  1