Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

A Responsive product review webpage using HTML and CSS

ayesoroboluโ€ข 140

@ayesorobolu

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of how well my responsiveness came out, even though it isn't perfect, it works very fine. I would try to make it more accurate.

What challenges did you encounter, and how did you overcome them?

I encountered challenges on making the site responsive, but i watched some tutorials, and it helped.

What specific areas of your project would you like help with?

I'm just having an issue, there's always excess space under my containers after i finish coding and inspect the webpage.

Community feedback

Daniel ๐Ÿ›ธโ€ข 44,230

@danielmrz-dev

Posted

Hello there!

Congrats on completing the challenge! โœ…

Your project looks great!

I have a suggestion about your code that might interest you:

๐Ÿ“Œ You can use the <picture> tag when you have different versions of the same image.

Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

Example:

<picture>
    <source media="(min-width: 768px)" srcset="{desktop image path here}">
    <img src="{mobile image path here}" alt="{alternative text here}">
</picture>

I hope this helps!

Other than that, excellent work!

Marked as helpful

0
P
Koda๐Ÿ‘นโ€ข 3,810

@kodan96

Posted

hi there! ๐Ÿ‘‹

If you meant that there's scrolling on your page it's because you applied height: 100vh on your <main> tag. this means this tag will always take up the entire screen, no matter how much content it contains.

This is a good approach for centering your content when the entire page is 100vh or smaller than that, but since your .attribution is outside of the main tag (which is a big red flag btw, all your content should be wrapped inside the header, main or footer tags), it causes overflow and scrolling.

you can either place the .attribution inside the main tag and give your card some margin to separate them from each other or you can give the attribution position: absolute; and make it stick to the bottom of the viewport.

Hope this helped ๐Ÿ™

Good luck and happy coding! ๐Ÿ™Œ

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord