A responsive NewsLetter Space :)

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  Good job completing the challenge successfully! Good work with the layout. However there seems to be some issues, especially with the right section. When i see your app on my notebook, the text content seems to overflow their containers. This is because you have set height: 120px;

  • I'd suggest avoid giving fixed height or max-heights for elements/containers that contain text elements.Not only it might breakout your layout like in this case, but it will cause accessibility issue, when user changes their default font-size, text will overflow and break the layout, instead use paddings inside the container if necessary. It is better to use min-height etc. but never a fixed height.

  Hope you find this feedback helpful!

  0