A React component that renders a product's data. Styled with vanilla c

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  Hi Jeffrey Onuigbo, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Jeffrey Onuigbo•70

  @JeffreyonPosted about 2 years ago

  @AdrianoEscarabote Thanks man, i appreciate your advice

  Truth is, i've never really understood rem and em units but your explanation just made me interested in trying it out. Thanks for the extention rec too!!

  About the h1 yeah, i feel you. I'll apply these on the next project 💪

  1