Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

A qr-components card

@Ehmkayel

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I will be glad if you can help to view my code to check where I need to improve on

Community feedback

@AkamineFabio

Posted

I would use relative units for paddings, but this is just my opinion. I like to use relative units, cause if you change the font-size, your paddings and other things will keep the proportion with the font-size. Again, only my opinion, I'm new in web developer's world, but this is something I see often, developers using relative units, cause then for example, in a project, your client ask you to change the font-size, you would need to change everything you use px. If you put those relative sizes, you just need change the font-size and everything will keep the proportion. Sorry for my bad english, I'm brazilian and I'm still improving my english skills :)

Marked as helpful

0

@Ehmkayel

Posted

Thank you for taking your time to read my code and pointing out the relative units, I really appreciate it. I will use that on my next project on frontend mentor challenges. Though I used relative units in some of my projects on github you can check them out github @AkamineFabio

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord