@saifion33
Posted
Hi Sahil.
Your solution is nice, however there is some issue if you want to improve check following tips.
-
Wrap
<div id="box">
into<main>
tag. -
Use
h1
tag instead ofh2
and there is no need of<b>
tag<h1 class="Highlighted-text">Improve your front-end skills by building projects</h1>
-
You have separate stylesheet so don't set image height and width with inline css
<img class="img" src="images/image-qr-code.png" alt="image-qr-code" >
set image height and width in style.css -
Don't use
<br>
tag because isn't best practice. -
Remove ```<div class="footer"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://github.com/Sahil-Sayyad/QR-code-component">Sahil Sayyad</a>.
- Don't center div like this
margin-top: 100px;
andmargin-left: 490px;
For more reference see my solution
I hope you find this helpful
Happy Coding😊