A perfect challenge for beginners

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Mohamed Khaled,

  Another great solution. I have some suggestions regarding your solution:

  • The alternate text of the logo should not be Main Logo, it may set alt=”Huddle". Use the website's name as an alternate text.Remember that a website-logo is one of the most meaningful images on a site so use proper alt for it.

  • For social links class="social", the icons are decorative, so you should add aria-hidden=”true” to the icons, to be ignored by screen readers and to avoid redundancy and repetition.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Mohamed Khaled•190

  @mohamedKhaled89Posted about 2 years ago

  @PhoenixDev22 Thanks a lot for your feedback.

  • I used Huddle instead of main logo I think it's excellent advice.
  • but I can't understand why icons here are decorative.
  • and the third one I don't know what you are talking about.

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @mohamedKhaled89 For your question , you can read more here. Happy coding!

  0
• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Mohamed, congrats on finishing the challenge, pretty good job and it looks that your page is fully responsive, great!

  If you don't mind I would like to give you some feedback.

  It would make your application look smoother and more beautifull if you add some transitions on your buttons and social media icons when hovering, you could add something like transition: all 0.5s ease;, remember to add them inside the class and not in the :hover pseudoclass, I think this is just a little change but will be a boost for the user experience.

  Also would recommend you to use more semantic tags like section or article instead of just dividing all of your main with divs, it will boost the accesibility of your page and also the search engines will position your web better.

  Hope my feedback helps you, great job and keep it going, almost pixel perfect!

  Marked as helpful

  1

  ---

  

  Mohamed Khaled•190

  @mohamedKhaled89Posted about 2 years ago

  @DavidMorgade Thanks a lot for your feedback.

  • I think adding transition is excellent advice
  • I will put into my consideration to use semantic tags next time

  thanks a lot again for your help

  0
• 

  Adam M•550

  @AdamMzkrPosted about 2 years ago

  Good Job but, in mobile view your design as a little bit to big. To see all content you need to scroll horizontally. I think change width container to 90% will help.

  Marked as helpful

  1

  ---

  

  Mohamed Khaled•190

  @mohamedKhaled89Posted about 2 years ago

  @AdamMzkr Thanks a lot for your feedback.

  • I always focus on width from 375px to 1440px
  • in which width is the problem

  0