Skip to content
Submitted 10 months ago

A Mobile-First Solution Using CSS FlexBox

konja kuma sampson•270
@DR-KSP-VIRUS
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

  1. I am not certain about the device breakpoints. Can I get help on how to write media queries for the code to be responsive to all devices?

  2. Is my code following the best practices?

Community feedback

  • Daniel 🛸•44,250
    @danielmrz-devPosted 10 months ago

    Hello @DR-KSP-VIRUS!

    Your solution looks great!

    I have a suggestion for improvement:

    • For semantic reasons, use main to wrap the main content instead of a div. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    1
  • Jojo-onedev•300
    @Jojo-onedevPosted 10 months ago

    Good job but I notice that your design is responsive on mobile

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord