A Mobile-First QR Code Component Design

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted 9 months ago

  Greetings Rora

  Congratulations for completing your first challenge. Well done, here are a few points to consider.

  • some of the elements to consider when creating a website are landmark elements. They provide a powerful way to structure your website and these include the main, header and footer. In this challenge I think we should be having the main element. For information read the following article on landmark elements
  • all images should have an alt attribute, where decorative images can have an empty value, the image in this challenge seems to be sending a message to users - hence it should be descriptive
  • the component is not centered like on the design - that can be achieved with using flex as you have done on the body and additional adding min-height: 100vh instead of the height property.
  • this challenge can be done without a media query, the .card component should use a max-width property instead of the width property. Let your sizes be in rems as well as the font-sizes

  Marked as helpful

  0

  ---

  

  Rora Alem•220

  @Rgit915Posted 9 months ago

  Hello @ChamuMutezva,

  Thank you for your thoughtful feedback. I appreciate the time you took to provide such valuable insights. Thanks for your guidance; I'll implement these changes to improve my solution and keep these principles in mind for future projects.

  0