A Mobile-First Design of a Card Using CSS FlexBox
Design comparison
Solution retrospective
I am very excited about this design.
However, I still have challenges regarding semantic HTML
and how to write code to improve SEO.
I humbly request your feedback on this.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @DR-KSP-VIRUS!
Your solution looks excellent!
I have a couple of suggestions:
- Use
main
to wrap the main content instead ofmain
andsection
.
š The tag
section
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.- Also, in order to make your HTML code more semantic, use
<h1>
for the main title instead ofh2
. Unlike what most people think, it's not just about the size and weight of the text.
š The
<h1>
to<h6>
tags are used to define HTML headings.š
<h1>
defines the most important heading.š
<h6>
defines the least important heading.š Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.Those tag changes have little or not effect at all on the project, but they make your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord