@vanzasetia
Posted
Hi, Paulo! 👋
About your CSS, you grouped the CSS properties and give a whitespace to separate each group. That is great. It can help you find certain properties faster. It looks like the size properties are always at the top, am I right?
For the order of the CSS properties, I use the Concentric CSS — Concentric-CSS/style3.css at master · brandon-rhodes/Concentric-CSS · GitHub. I was manually writing my CSS properties. Now, I use an NPM package called css-declaration-sorter with PostCSS. You need to do some setup to get it up and running.
As a side note, you need to know that grouping CSS properties and the order of writing the CSS properties are not necessary things to do. It is just a preference.
For CSS selectors, I recommend following this guide:
- Keep the CSS specificity as low and flat as possible: Don't nest selectors unnecessarily.
- Avoid
id
selectors: Do not useid
selectors for styling. They mess up specificity because they are too high (the most important reason). Also, they are unique identifiers. So, they are not reusable on the same page.
For the background image, I do not see any problem. I used a media query to change the mobile background pattern to a desktop one.
I hope this helps. Happy coding! 😄